From 1ffe225fbbd15cb7548d3c93eedec3467ac8bceb Mon Sep 17 00:00:00 2001 From: Thomas Lynch Date: Mon, 24 Aug 2020 11:07:48 +0000 Subject: [PATCH] small math error --- helpers/captcha/generators/grid.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/helpers/captcha/generators/grid.js b/helpers/captcha/generators/grid.js index f8b1c3bd..2536a2b1 100644 --- a/helpers/captcha/generators/grid.js +++ b/helpers/captcha/generators/grid.js @@ -14,7 +14,7 @@ const gm = require('gm').subClass({ imageMagick: true }) do { rand = (await randomBytes(numberBytes)).readUIntBE(0, numberBytes); rand = rand & mask; - } while (rand > mod); + } while (rand >= mod); return rand + min; } , padding = 30 @@ -33,7 +33,7 @@ module.exports = async () => { //array of true/false, for each grid input const boolArray = Array.from(randBuffer).map(x => x < 80); if (!boolArray.some(b => b === true)) { - boolArray[(await randomRange(0,numInputs))] = true; + boolArray[(await randomRange(0,numInputs-1))] = true; } const captchaId = await Captchas.insertOne(boolArray).then(r => r.insertedId);