From f6631068d1075b0670df1679f8d3b3d929caf2af Mon Sep 17 00:00:00 2001 From: some random guy Date: Sun, 3 Jul 2022 15:39:45 +0200 Subject: [PATCH 1/2] captcha/getdistorts: randomRange requires integers --- lib/captcha/getdistorts.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/captcha/getdistorts.js b/lib/captcha/getdistorts.js index f16696c8..03fd2601 100644 --- a/lib/captcha/getdistorts.js +++ b/lib/captcha/getdistorts.js @@ -13,8 +13,8 @@ module.exports = async (width, height, numDistorts, distortion) => { for (let i = 0; i < randNumDistorts; i++) { //start and end of divided width - const divStart = (div * i) - , divEnd = (div * (i + 1)); + const divStart = Math.floor(div * i) + , divEnd = Math.floor(div * (i + 1)); //origin coordinate for distortion point const originx = await randomRange(divStart, divEnd) From cfa5a045066837fa2527b872ed5069afaf25926c Mon Sep 17 00:00:00 2001 From: Thomas Lynch Date: Mon, 4 Jul 2022 21:21:38 +1000 Subject: [PATCH 2/2] version bump and CHANGELOG update for fix --- CHANGELOG.md | 3 +++ package-lock.json | 4 ++-- package.json | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a86c969d..978809a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +### 0.7.3 + - Bugfix some captcha generations causing server error due non-integer argument to randomRange. + ### 0.7.2 - Add playlist generating bookmarklet script to README - Bugfix some captcha generations causing server error due to bad random number range. diff --git a/package-lock.json b/package-lock.json index 592c7f35..9f0d228f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "jschan", - "version": "0.7.1", + "version": "0.7.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "jschan", - "version": "0.7.1", + "version": "0.7.3", "license": "AGPL-3.0-only", "dependencies": { "@fatchan/express-fileupload": "^1.4.0", diff --git a/package.json b/package.json index f1c3a967..18a4e02e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "jschan", - "version": "0.7.2", + "version": "0.7.3", "migrateVersion": "0.6.5", "description": "", "main": "server.js",