From 69b37e2a35a2b32567acac8d15392144efb0c5bb Mon Sep 17 00:00:00 2001 From: fatchan Date: Sat, 13 Jul 2019 16:01:33 +0100 Subject: [PATCH] preview backlink corrections for 0 links and incorrect indexOf for all 5 --- db/posts.js | 6 +++--- views/mixins/post.pug | 15 ++++++--------- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/db/posts.js b/db/posts.js index bf0ee592..eaa8ea02 100644 --- a/db/posts.js +++ b/db/posts.js @@ -60,10 +60,10 @@ module.exports = { //if enough replies, show omitted count if (thread.replyposts > 5) { //dont show ALL backlinks on OP for previews on index page - const firstPreviewId = thread.replies[0].postId; - const latestPreviewBacklink = thread.backlinks.find(bl => { return bl.postId >= firstPreviewId }); + const firstPreviewId = thread.replies[0].postId; //34 + const latestPreviewBacklink = thread.backlinks.find(bl => { return bl.postId >= firstPreviewId }); //post with 34 if (latestPreviewBacklink != null) { - const latestPreviewIndex = thread.backlinks.map(bl => bl.postId).indexOf(latestPreviewBacklink); + const latestPreviewIndex = thread.backlinks.map(bl => bl.postId).indexOf(latestPreviewBacklink.postId); thread.previewbacklinks = thread.backlinks.slice(latestPreviewIndex); } else { thread.previewbacklinks = []; diff --git a/views/mixins/post.pug b/views/mixins/post.pug index e0ddd9fd..ab8a650a 100644 --- a/views/mixins/post.pug +++ b/views/mixins/post.pug @@ -92,16 +92,13 @@ mixin post(post, truncate, manage=false, globalmanage=false) blockquote.banmessage USER BANNED FOR THIS POST (#{post.banmessage || 'No reason specified'}) if post.omittedposts || post.omittedimages blockquote.muted #{post.omittedposts} post(s)#{post.omittedimages > 0 ? ' and '+post.omittedimages+' image(s)' : ''} omitted. #[a(href=`${postURL}#${post.postId}`) View the full thread] - if post.previewbacklinks + if post.previewbacklinks && post.previewbacklinks.length > 0 .replies Replies: - if post.previewbacklinks.length === 0 - | #{post.backlinks.length-post.previewbacklinks.length} reply link(s) omitted - else - each backlink in post.previewbacklinks - a.quote(href=`/${post.board}/thread/${post.thread || post.postId}.html#${backlink.postId}`) >>#{backlink.postId} - | - if post.previewbacklinks.length < post.backlinks.length - | + #{post.backlinks.length-post.previewbacklinks.length} reply link(s) omitted + each backlink in post.previewbacklinks + a.quote(href=`/${post.board}/thread/${post.thread || post.postId}.html#${backlink.postId}`) >>#{backlink.postId} + | + if post.previewbacklinks.length < post.backlinks.length + | + #{post.backlinks.length-post.previewbacklinks.length} reply link(s) omitted else if post.backlinks && post.backlinks.length > 0 .replies Replies: each backlink in post.backlinks