From 473eb94d394efe714b4a3ddcb3a3b6aa523354eb Mon Sep 17 00:00:00 2001
From: Thomas Lynch <tom@69420.me>
Date: Fri, 20 Jan 2023 18:22:04 +1100
Subject: [PATCH] Update permission.test.js to correctly expect() the .every
 rather than in the every callback, else it would only check the first one

---
 lib/permission/permission.test.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lib/permission/permission.test.js b/lib/permission/permission.test.js
index 3d782d16..401fa4f9 100644
--- a/lib/permission/permission.test.js
+++ b/lib/permission/permission.test.js
@@ -34,14 +34,14 @@ describe('testing permissions', () => {
 	]);
 
 	test('BO has all board perms', () => {
-		Permissions._MANAGE_BOARD_BITS.every(b => expect(BOARD_OWNER.get(b)).toBe(true));
+		expect(Permissions._MANAGE_BOARD_BITS.every(b => BOARD_OWNER.get(b))).toBe(true);
 	});
 
 	test('applyInheritance() gives BO all board perms as long as they have Permissions.MANAGE_BOARD_OWNER', () => {
 		BOARD_OWNER.setAll(Permissions._MANAGE_BOARD_BITS, false);
 		BOARD_OWNER.set(Permissions.MANAGE_BOARD_OWNER);
 		BOARD_OWNER.applyInheritance();
-		Permissions._MANAGE_BOARD_BITS.every(b => expect(BOARD_OWNER.get(b)).toBe(true));
+		expect(Permissions._MANAGE_BOARD_BITS.every(b => BOARD_OWNER.get(b))).toBe(true);
 	});
 
 	const GLOBAL_STAFF = new Permission(BOARD_OWNER.base64);
@@ -58,13 +58,13 @@ describe('testing permissions', () => {
 	ROOT.setAll(Permission.allPermissions);
 
 	test('root has all permissions', () => {
-		Permission.allPermissions.every(p => expect(ROOT.get(p)).toBe(true));
+		expect(Permission.allPermissions.every(p => ROOT.get(p))).toBe(true);
 	});
 
 	test('applyInheritance() gives ROOT all permissions as long as they have Permissions.ROOT', () => {
 		NO_PERMISSION.set(Permissions.ROOT);
 		NO_PERMISSION.applyInheritance();
-		Permission.allPermissions.every(b => expect(NO_PERMISSION.get(b)).toBe(true));
+		expect(Permission.allPermissions.every(b => NO_PERMISSION.get(b))).toBe(true);
 	});
 
 	//todo: what othe rpermissions test should be added?