From e18b4419d0577ded104fcb1a92e83ac2867180f2 Mon Sep 17 00:00:00 2001
From: fatchan <tom@69420.me>
Date: Tue, 3 Sep 2019 11:48:32 +0000
Subject: [PATCH] decrement files on post failure only when posts actually
 exist

---
 controllers/forms/makepost.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/controllers/forms/makepost.js b/controllers/forms/makepost.js
index 97b56b42..62a6d97b 100644
--- a/controllers/forms/makepost.js
+++ b/controllers/forms/makepost.js
@@ -80,7 +80,9 @@ module.exports = async (req, res, next) => {
 		await makePost(req, res, next);
 	} catch (err) {
 		await deleteTempFiles(req).catch(e => console.error);
-		await Files.decrement(req.files.file.filter(x => x.filename != null).map(x => x.filename)).catch(e => console.error);
+		if (res.locals.numFiles > 0) {
+			await Files.decrement(req.files.file.filter(x => x.filename != null).map(x => x.filename)).catch(e => console.error);
+		}
 		return next(err);
 	}